Skip to content

Ruff linting#151

Merged
Schamper merged 2 commits intofox-it:mainfrom
william-billaud:ruff_lintinf
Mar 19, 2026
Merged

Ruff linting#151
Schamper merged 2 commits intofox-it:mainfrom
william-billaud:ruff_lintinf

Conversation

@william-billaud
Copy link
Contributor

Add ruff rules related to docstring, import and annotations

Comment on lines 41 to 44
"""Args:
cs: An instance of cstruct.
compiled: Whether structs should be compiled or not.
"""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could use a starting sentence.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@codecov
Copy link

codecov bot commented Mar 19, 2026

Codecov Report

❌ Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.00%. Comparing base (96644dd) to head (33c8328).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
dissect/cstruct/types/structure.py 0.00% 2 Missing ⚠️
dissect/cstruct/__init__.py 0.00% 1 Missing ⚠️
dissect/cstruct/exceptions.py 0.00% 1 Missing ⚠️
dissect/cstruct/parser.py 0.00% 1 Missing ⚠️
dissect/cstruct/types/__init__.py 0.00% 1 Missing ⚠️
dissect/cstruct/types/enum.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main    #151   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         21      21           
  Lines       2435    2438    +3     
=====================================
- Misses      2435    2438    +3     
Flag Coverage Δ
unittests 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Schamper Schamper merged commit 1e2110a into fox-it:main Mar 19, 2026
21 checks passed
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 19, 2026

Merging this PR will not alter performance

✅ 12 untouched benchmarks


Comparing william-billaud:ruff_lintinf (33c8328) with main (96644dd)

Open in CodSpeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add stricter ruff linting

2 participants